Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[TUTORIAL] Gluon and Sparse NDArray #15396

Merged
merged 2 commits into from
Jul 4, 2019

Conversation

thomelane
Copy link
Contributor

Description

Added a brand new tutorial on how to use Sparse NDArray with Gluon API. Other tutorials on Sparse NDArray exist but cover low-level details and Module API, not Gluon API. Also shows how to handle data using LibSVM, and why to avoid Dataset and DataLoader. And provides an implementation of a Gluon Block that can be used efficiently with sparse input (unlike nn.Dence).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@thomelane thomelane requested a review from szha as a code owner June 28, 2019 00:52
@thomelane
Copy link
Contributor Author

@eric-haibin-lin @aaronmarkham please review, thanks!

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jun 28, 2019
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some missing links and minor suggestions. Overall, it looks great.

docs/tutorials/sparse/train_gluon.md Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! Looks good to me. One comment

docs/tutorials/sparse/train_gluon.md Outdated Show resolved Hide resolved
@thomelane
Copy link
Contributor Author

thanks for the reviews @eric-haibin-lin @aaronmarkham. updates made.

@aaronmarkham aaronmarkham merged commit d7c542a into apache:master Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants